Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gasper changes for gctltoken generation #237

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

ZainulNiaz
Copy link

@@ -0,0 +1,6 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this file?

services/master/routes.go Outdated Show resolved Hide resolved
@@ -34,6 +34,19 @@ func authenticator(c *gin.Context) (interface{}, error) {
return user, nil
}

func authenticatorForGctl(c *gin.Context) (interface{}, error) {
auth := &types.Login{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we decide to change this type? Is it working without a password in the request body?

@@ -34,6 +34,19 @@ func authenticator(c *gin.Context) (interface{}, error) {
return user, nil
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment here that this function doesn't authenticate as authentication is already done in middleware.. this function is just to get the user

@ZainulNiaz ZainulNiaz force-pushed the gctltoken branch 2 times, most recently from f1aaebf to fd1a268 Compare February 18, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants