Fiber thermal shift refinement #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.1.1dev data a number of exposures (e.g., 5006, 5336) have failed fiber thermal shift measurements. Here are some examples:
https://data.sdss5.org/sas/sdsswork/lvm/spectro/redux/1.1.1dev/0011XX/11111/60208/ancillary/qa/lvm-xobject-b2-00005336_fiber_thermal_shifts.png
https://data.sdss5.org/sas/sdsswork/lvm/spectro/redux/1.1.1dev/0011XX/11111/60202/ancillary/qa/lvm-xobject-z2-00005006_fiber_thermal_shifts.png
These failure seems to originate in the first guess of the fiber thermal shift coming from
align_blockswhen a few fibers dominate one or more blocks.This PR fixes this issue by removing as much as possible fiber features during
align_blocksso that only fiber blocks are cross matched.