Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose reports module in top-level init #459

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

frances-h
Copy link
Contributor

In order for add-ons to work correctly with the reports, we need to expose them to the top-level init.

@frances-h frances-h requested a review from a team as a code owner October 2, 2023 17:21
@frances-h frances-h requested review from rwedge and pvk-developer and removed request for a team October 2, 2023 17:21
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (35978c4) 77.13% compared to head (e9de32f) 77.16%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   77.13%   77.16%   +0.02%     
==========================================
  Files          93       93              
  Lines        3442     3446       +4     
==========================================
+ Hits         2655     2659       +4     
  Misses        787      787              
Files Coverage Δ
sdmetrics/__init__.py 80.00% <ø> (ø)
sdmetrics/reports/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frances-h frances-h merged commit bc92a5e into main Oct 3, 2023
45 checks passed
@frances-h frances-h deleted the fix-report-imports branch October 3, 2023 19:57
@rwedge rwedge added this to the 0.12.0 milestone Oct 31, 2023
@rwedge rwedge added the feature:reports Related to any of the generated reports label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:reports Related to any of the generated reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants