Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide meta information about the reports #472

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Provide meta information about the reports #472

merged 2 commits into from
Oct 24, 2023

Conversation

frances-h
Copy link
Contributor

@frances-h frances-h commented Oct 17, 2023 •
edited
Loading

CU-860q8k97g

@frances-h frances-h requested a review from a team as a code owner October 17, 2023 14:49
@frances-h frances-h requested review from pvk-developer and removed request for a team October 17, 2023 14:49
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (bc92a5e) 76.84% compared to head (94e8302) 76.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   76.84%   76.96%   +0.11%     
==========================================
  Files          93       93              
  Lines        3395     3412      +17     
==========================================
+ Hits         2609     2626      +17     
  Misses        786      786
Files Coverage Δ
sdmetrics/reports/base_report.py 99.10% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frances-h frances-h requested a review from amontanez24 October 17, 2023 15:19
amontanez24
amontanez24 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

amontanez24
amontanez24 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe we can move the issue from private over to this repo and tag it

@npatki
Copy link
Contributor

npatki commented Oct 24, 2023

Unfortunately, I think you can only transfer issues within a single organization (like sdv-dev)n

pvk-developer
pvk-developer approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: !

@frances-h frances-h merged commit 7f39ca7 into main Oct 24, 2023
45 checks passed
@frances-h frances-h deleted the provide-meta-information-about-reports branch October 24, 2023 17:02
@rwedge rwedge added the feature:reports Related to any of the generated reports label Oct 31, 2023
@rwedge rwedge added this to the 0.12.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees

@frances-h frances-h

Labels
feature:reports Related to any of the generated reports
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
6 participants
@frances-h @codecov-commenter @npatki @amontanez24 @pvk-developer @rwedge