-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Structure
property
#483
Add Structure
property
#483
Conversation
@R-Palazzo seems OK for an MVP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@R-Palazzo one small title change. I also wonder if you can share a screenshot of the tooltip (on-hover) to verify that it makes sense for the visualization.
fig = px.bar( | ||
data_frame=self.details.dropna(subset=['Score']), | ||
y='Score', | ||
title=f'Data Diagnostics: Structure (Average Score={round(average_score, 2)})', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@R-Palazzo Title should be Data Diagnostic (singular, not plural)
We should make sure the title of these visualizations are consistent everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in 620285f
b793e9f
to
620285f
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## diagnostic_report_updates #483 +/- ##
=============================================================
- Coverage 77.67% 77.67% -0.01%
=============================================================
Files 97 99 +2
Lines 3508 3548 +40
=============================================================
+ Hits 2725 2756 +31
- Misses 783 792 +9
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good 👍
CU-86ayg9qwy
Resolve #468
Let me know if this visualization works @frances-h, @npatki