Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest dependency checker workflow #549

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

lajohn4747
Copy link
Contributor

resolves #547
CU-86azw20nz

Add dependency checker github action and command to see if library works with latest dependencies

@sdv-team
Copy link
Contributor

sdv-team commented Apr 3, 2024

@lajohn4747 lajohn4747 marked this pull request as ready for review April 3, 2024 15:10
@lajohn4747 lajohn4747 requested a review from a team as a code owner April 3, 2024 15:10
@lajohn4747 lajohn4747 requested review from amontanez24 and removed request for a team April 3, 2024 15:10
@lajohn4747 lajohn4747 marked this pull request as draft April 3, 2024 15:11
@amontanez24 amontanez24 requested a review from gsheni April 3, 2024 15:31
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.52%. Comparing base (5fe4551) to head (73eb9ce).

❗ Current head 73eb9ce differs from pull request most recent head 084d238. Consider uploading reports for the commit 084d238 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage   78.52%   78.52%           
=======================================
  Files         102      102           
  Lines        3726     3726           
=======================================
  Hits         2926     2926           
  Misses        800      800           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lajohn4747 lajohn4747 requested review from gsheni and amontanez24 April 3, 2024 21:59
@lajohn4747 lajohn4747 marked this pull request as ready for review April 3, 2024 22:00
- name: Install dependencies
run: |
python -m pip install .[dev]
make check-deps OUTPUT_FILEPATH=latest_requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, this will output the file in the root directory. We could put this in tests or somewhere else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is fine to be in root but I have no preference on where it should go (kept it consistent with the other dependency checker)
cc: @amontanez24 for input

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm fine with it

@lajohn4747 lajohn4747 requested a review from gsheni April 3, 2024 23:05
@lajohn4747 lajohn4747 merged commit 2b85305 into main Apr 4, 2024
45 checks passed
@lajohn4747 lajohn4747 deleted the issue_547_dependency_checker branch April 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependency checker
5 participants