-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest dependency checker workflow #549
Conversation
Task linked: CU-86azw20nz SDMetrics - Add dependency checker #547 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 102 102
Lines 3726 3726
=======================================
Hits 2926 2926
Misses 800 800 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- name: Install dependencies | ||
run: | | ||
python -m pip install .[dev] | ||
make check-deps OUTPUT_FILEPATH=latest_requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note, this will output the file in the root directory. We could put this in tests or somewhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it is fine to be in root but I have no preference on where it should go (kept it consistent with the other dependency checker)
cc: @amontanez24 for input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm fine with it
resolves #547
CU-86azw20nz
Add dependency checker github action and command to see if library works with latest dependencies