Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow get_column_pair_plot to visualize one dataset instead of both real and synthetic #595

Merged
merged 9 commits into from
Jun 25, 2024

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Jun 20, 2024

PR for 1 of 3 graphs to be able show real and synthetic separately using a None for one of the datasets.

This PR is for get_column_pair_plot and the relevant tests

Part of issue #581
CU-86b0t56r9

get_column_pair_plot_heat_both
get_column_pair_plot_heat_real
get_column_pair_plot_heat_synth
get_column_pair_plot_scatter_both
get_column_pair_plot_scatter_real
get_column_pair_plot_scatter_synth

@lajohn4747 lajohn4747 requested a review from a team as a code owner June 20, 2024 16:17
@sdv-team
Copy link
Contributor

@lajohn4747 lajohn4747 removed the request for review from a team June 20, 2024 18:33
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add tests for only one column for both _generate_scatter_plot and _generate_heatmap_plot

sdmetrics/visualization.py Outdated Show resolved Hide resolved
sdmetrics/visualization.py Outdated Show resolved Hide resolved
@lajohn4747 lajohn4747 requested a review from amontanez24 June 24, 2024 20:12
@lajohn4747 lajohn4747 requested a review from amontanez24 June 24, 2024 20:55
@lajohn4747 lajohn4747 merged commit 9faf45d into main Jun 25, 2024
47 checks passed
@lajohn4747 lajohn4747 deleted the issue_581_get_column_pair_plot branch June 25, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants