Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow get_column_plot to graph synthetic and real data individually #596

Merged
merged 23 commits into from
Jun 25, 2024

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Jun 20, 2024

Part 2 of 3 for allowing visualizations to work with a single dataset: #581
CU-86b0t56r9

This PR is to handle get_column_plot

get_column_plot_bar_both
get_column_plot_bar_real
get_column_plot_bar_synth
get_column_plot_dist_both
get_column_plot_dist_real
get_column_plot_dist_synth

@lajohn4747 lajohn4747 requested a review from a team as a code owner June 20, 2024 20:28
@sdv-team
Copy link
Contributor

@npatki
Copy link
Contributor

npatki commented Jun 20, 2024

Hi @lajohn4747 the request was to always have the correct color -- so when you're doing synthetic data, it should be light blue, not dark blue. However, all of your graphs are the darker color. Could you update this?

@lajohn4747 lajohn4747 changed the title Issue 581 get column plot Allow get_column_plot to graph synthetic and real data individually Jun 20, 2024
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it doesn't seem like there are any unit tests for _generate_column_plot and that is mocked in the test for get_column_plot so a lot of this functionality seems to be untested. This seems to come from before this PR but can you either

  1. Add tests for _generate_column_plot or
  2. Remove the mock and make sure everything is behaving as expected
    If you do the second one you can mock px and ff so you don't have to graph anything and can just ealuate the right inputs are being passed

@lajohn4747 lajohn4747 requested a review from amontanez24 June 24, 2024 17:25
@lajohn4747 lajohn4747 requested a review from amontanez24 June 24, 2024 18:36
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from issue_581_get_column_pair_plot to main June 25, 2024 17:32
@lajohn4747 lajohn4747 merged commit 647525d into main Jun 25, 2024
47 checks passed
@lajohn4747 lajohn4747 deleted the issue_581_get_column_plot branch June 25, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants