-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow get_column_plot
to graph synthetic and real data individually
#596
Conversation
Hi @lajohn4747 the request was to always have the correct color -- so when you're doing synthetic data, it should be light blue, not dark blue. However, all of your graphs are the darker color. Could you update this? |
get_column_plot
to graph synthetic and real data individually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but it doesn't seem like there are any unit tests for _generate_column_plot
and that is mocked in the test for get_column_plot
so a lot of this functionality seems to be untested. This seems to come from before this PR but can you either
- Add tests for
_generate_column_plot
or - Remove the mock and make sure everything is behaving as expected
If you do the second one you can mock px and ff so you don't have to graph anything and can just ealuate the right inputs are being passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part 2 of 3 for allowing visualizations to work with a single dataset: #581
CU-86b0t56r9
This PR is to handle
get_column_plot