Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests failing due to scipy 1.14 #601

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fix tests failing due to scipy 1.14 #601

merged 2 commits into from
Jun 26, 2024

Conversation

lajohn4747
Copy link
Contributor

@lajohn4747 lajohn4747 commented Jun 26, 2024 •
edited
Loading

Failing tests due to scipy 1.14

Tests were failing due to two reasons:

  • Scipy changed there error messages
  • Scipy ks_2samp does not throw value error if nans are passed in anymore
  • It seems float point accuracy increased

@lajohn4747 lajohn4747 requested a review from a team as a code owner June 26, 2024 00:38
@lajohn4747 lajohn4747 requested a review from amontanez24 June 26, 2024 15:19
@lajohn4747 lajohn4747 merged commit 7b4fc9f into main Jun 26, 2024
47 checks passed
@lajohn4747 lajohn4747 deleted the fix_scipy_1_14 branch June 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Palazzo R-Palazzo R-Palazzo approved these changes

@amontanez24 amontanez24 amontanez24 approved these changes

Assignees

@lajohn4747 lajohn4747

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lajohn4747 @amontanez24 @R-Palazzo