Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that every property score are index-free #611

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Check that every property score are index-free #611

merged 2 commits into from
Jul 25, 2024

Conversation

R-Palazzo
Copy link
Contributor

CU-86b0tvz6j
Resolve #583

@R-Palazzo R-Palazzo requested review from rwedge and lajohn4747 July 24, 2024 13:33
@R-Palazzo R-Palazzo self-assigned this Jul 24, 2024
@R-Palazzo R-Palazzo requested a review from a team as a code owner July 24, 2024 13:33
@sdv-team
Copy link
Contributor

Task linked: CU-86b0tvz6j SDMetrics - Check that every property score are index-free #583

@R-Palazzo R-Palazzo removed the request for review from a team July 24, 2024 13:33
lajohn4747
lajohn4747 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@lajohn4747 lajohn4747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad it was fixed previously and we only needed a test for this 👍

@R-Palazzo R-Palazzo merged commit 9d5f503 into main Jul 25, 2024
94 checks passed
@R-Palazzo R-Palazzo deleted the issue-583-property-index-free branch July 25, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lajohn4747 lajohn4747 lajohn4747 approved these changes

@rwedge rwedge rwedge approved these changes

Assignees

@R-Palazzo R-Palazzo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that every property score are index-free
4 participants
@R-Palazzo @sdv-team @rwedge @lajohn4747