Add metric for inter-row MSAS #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
force-pushed
the
issue-640-interow
branch
6 times, most recently
from
0aaab75 to
cc4fb91
Compare
fealho
force-pushed
the
issue-640-interow
branch
from
cc4fb91 to
97a28e1
Compare
fealho
requested review from
frances-h,
R-Palazzo and
amontanez24
and removed request for
a team
fealho
commented
Oct 29, 2024
sdmetrics/timeseries/inter_row.py
Outdated
| differences = [] | ||
| for key in keys.unique(): | ||
| group_values = values[keys == key].to_numpy() | ||
| if len(group_values) > n_rows_diff: |
There was a problem hiding this comment.
If n_rows_diff is larger than the sequence lengths, np.mean(diff) is np.nan. The KSComplement doesn't support np.nan values for python 3.8.
There was a problem hiding this comment.
Should we raise an error here?
There was a problem hiding this comment.
Can we add a test where n_rows_diff is larger than a sequence?
fealho
changed the base branch from
main
to
feature-branch-timeseries-metrics
amontanez24
reviewed
Oct 30, 2024
sdmetrics/timeseries/inter_row.py
Outdated
| differences = [] | ||
| for key in keys.unique(): | ||
| group_values = values[keys == key].to_numpy() | ||
| if len(group_values) > n_rows_diff: |
There was a problem hiding this comment.
Should we raise an error here?
frances-h
reviewed
Oct 31, 2024
frances-h
reviewed
Nov 4, 2024
Comment on lines
+62
to
+63
| except ValueError as e: | ||
| if str(e) == 'Data passed to ks_2samp must not be empty': |
There was a problem hiding this comment.
Should we check the inputs instead of trying to catch the error from the error message?
There was a problem hiding this comment.
Only old versions of scipy raise this error, newer ones support empty data.
frances-h
approved these changes
Nov 4, 2024
R-Palazzo
approved these changes
Nov 4, 2024
fealho
added a commit
that referenced
this pull request
Nov 14, 2024
fealho
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b2evvby, Resolve #640.