Fix KSComplement instability for constant float values
#654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
changed the base branch from
main
to
feature-branch-timeseries-metrics
fealho
changed the title
KSComplement instability for constant float valuesKSComplement instability for constant float values
fealho
force-pushed
the
feature-branch-timeseries-metrics
branch
from
b8df54e to
83871df
Compare
fealho
force-pushed
the
issue-652-kscomplement
branch
from
8ffd48f to
d6654d7
Compare
fealho
force-pushed
the
issue-652-kscomplement
branch
3 times, most recently
from
133f722 to
7412dfb
Compare
fealho
force-pushed
the
issue-652-kscomplement
branch
from
7412dfb to
97538ad
Compare
fealho
requested review from
amontanez24 and
R-Palazzo
and removed request for
a team
fealho
commented
Nov 19, 2024
amontanez24
approved these changes
Nov 20, 2024
R-Palazzo
reviewed
Nov 25, 2024
tests/integration/single_column/statistical/test_kscomplement.py
Outdated
Show resolved
Hide resolved
R-Palazzo
approved these changes
Nov 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
==========================================
+ Coverage 94.16% 94.19% +0.03%
==========================================
Files 105 105
Lines 3943 3947 +4
==========================================
+ Hits 3713 3718 +5
+ Misses 230 229 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86b2t0z0c, Resolve #652.