Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for datetime values when apply_log = True for InterRowMSAS #673

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

fealho
Copy link
Member

@fealho fealho commented Nov 19, 2024

CU-86b2xaucz, Resolve #672.

@sdv-team
Copy link
Contributor

@fealho fealho marked this pull request as ready for review November 19, 2024 17:43
@fealho fealho requested a review from a team as a code owner November 19, 2024 17:43
@fealho fealho requested review from frances-h and R-Palazzo and removed request for a team November 19, 2024 17:43
Copy link
Contributor

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from issue-670-warnings-log to main November 22, 2024 17:59
@fealho fealho changed the base branch from main to curate_release_targets November 25, 2024 15:26
@fealho fealho changed the base branch from curate_release_targets to main November 25, 2024 15:26
@fealho fealho force-pushed the issue-672-error-log branch from 78e3b5b to a4ffbc5 Compare November 25, 2024 15:31
Copy link
Contributor

@R-Palazzo R-Palazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.16%. Comparing base (d2cb918) to head (370e472).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   94.11%   94.16%   +0.05%     
==========================================
  Files         105      105              
  Lines        3941     3943       +2     
==========================================
+ Hits         3709     3713       +4     
+ Misses        232      230       -2     
Flag Coverage Δ
integration 78.06% <0.00%> (+0.01%) ⬆️
unit 79.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fealho fealho merged commit 8b450df into main Nov 25, 2024
49 checks passed
@fealho fealho deleted the issue-672-error-log branch November 25, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error handling for datetime values when apply_log = True for InterRowMSAS
4 participants