Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link to repo install doc #266

Merged
merged 1 commit into from
Sep 23, 2024
Merged

update link to repo install doc #266

merged 1 commit into from
Sep 23, 2024

Conversation

daichifukui
Copy link
Contributor

As of writing this PR, the link to the repo installation documentation redirects to a page titled “Download the Android source,” which does not include instructions on how to install the repo.
Therefore, we would like to use a different link for the installation instructions.

Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is one of those that doesn't get caught by link checkers.

@lsf37
Copy link
Member

lsf37 commented Sep 9, 2024

@daichifukui the content is fine, but the PR check is complaining about the body of the commit message. Could you wrap the commit message body at 72 characters and remove the trailing space character at the end? That should make it pass. (And then it can be merged).

@lsf37 lsf37 self-assigned this Sep 9, 2024
As of writing this PR, the link to the repo installation documentation
redirects to a page titled “Download the Android source,”
which does not include instructions on how to install the repo.
Therefore, we would like to use a different link for the installation
instructions.

Signed-off-by: daichifukui <a.dog.will.talk@akane.waseda.jp>
@daichifukui
Copy link
Contributor Author

daichifukui commented Sep 10, 2024

@daichifukui the content is fine, but the PR check is complaining about the body of the commit message. Could you wrap the commit message body at 72 characters and remove the trailing space character at the end? That should make it pass. (And then it can be merged).

Sure, thanks for pointing this out. I've updated the commit message.

@lsf37 lsf37 merged commit 7c25115 into seL4:master Sep 23, 2024
8 checks passed
@lsf37
Copy link
Member

lsf37 commented Sep 23, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants