Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AArch64 container variants #65

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

Ivan-Velickovic
Copy link
Contributor

@Ivan-Velickovic Ivan-Velickovic commented Jun 21, 2023

Building seL4 projects and CAmkES projects should work now. The l4v container will build, but on ARM64 will be missing the mlton compiler.

Also includes CI setup (for PRs only for now) and README update.

Both, x64 and arm64 images should be working, but the setup is not yet a full multi-arch build where one container manifest contains both images at the same time. We can do that in a separate step.

Makefile Outdated Show resolved Hide resolved
scripts/sel4.sh Outdated Show resolved Hide resolved
scripts/sel4.sh Outdated Show resolved Hide resolved
@Ivan-Velickovic
Copy link
Contributor Author

I suggest something like ./build.sh -b camkes -a arm64 for selecting the architecture, if -a is omitted then we select the host architecture like is already done in the patch.

@kent-mcleod kent-mcleod marked this pull request as draft June 21, 2023 06:15
@lsf37
Copy link
Member

lsf37 commented May 12, 2024

I suggest something like ./build.sh -b camkes -a arm64 for selecting the architecture, if -a is omitted then we select the host architecture like is already done in the patch.

Sounds good.

Have rebased the branch and added a line to make stack available further down in the camkes.sh script. I'll have a look at making the rest conditional next.

@lsf37 lsf37 force-pushed the armv8_testing branch 14 times, most recently from 2de3f8d to ff2412c Compare May 13, 2024 01:44
scripts/sel4.sh Outdated Show resolved Hide resolved
scripts/sel4.sh Outdated Show resolved Hide resolved
@Ivan-Velickovic
Copy link
Contributor Author

build.sh Outdated Show resolved Hide resolved
@lsf37 lsf37 changed the title WIP of AArch64 container Add AArch64 container variants May 13, 2024
@lsf37 lsf37 linked an issue May 13, 2024 that may be closed by this pull request
@lsf37 lsf37 marked this pull request as ready for review May 13, 2024 09:33
Makefile Outdated Show resolved Hide resolved
@Ivan-Velickovic
Copy link
Contributor Author

I can't approve my own pull requests so I'll just leave a comment saying I don't see any issues with any of the changes.

@lsf37
Copy link
Member

lsf37 commented May 14, 2024

I can't approve my own pull requests so I'll just leave a comment saying I don't see any issues with any of the changes.

Perfect. I'll remove the comment you mentioned above and merge when the tests pass.

Ivan-Velickovic and others added 4 commits May 14, 2024 11:01
Add an AArch64 version of the seL4, CAmkES, and L4v containers. seL4 and
CAmkES should have full functionality, L4v will be missing the mlton
compiler.

The Intel containers remain available as before.

Co-authored-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
- remove obsolete options and settings
- spell check
- update github org URLs
- update descriptions to current seL4 CI
- update CLI instructions
- markdown lint

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Prevent the job from using cached images on the self-hosted runner to
make sure we are picking up the current state of the remote Debian repo.
GitHub runners start from scratch each time, so they won't have any
cached images available.

Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
@lsf37 lsf37 merged commit 68d9f70 into seL4:master May 14, 2024
10 checks passed
@Ivan-Velickovic Ivan-Velickovic deleted the armv8_testing branch May 14, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make user failed on MacBook Pro with Apple M1 chipset
2 participants