-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta og tags #39
Open
monkeywithacupcake
wants to merge
35
commits into
seankross:main
Choose a base branch
from
monkeywithacupcake:add-meta
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add meta og tags #39
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
95af35c
Update jolla-blue.html
monkeywithacupcake 33a021c
Update jolla.html
monkeywithacupcake e31ec66
Update onofre.html
monkeywithacupcake 6c7b220
Update trestles.html
monkeywithacupcake c096717
Update skeleton.Rmd
monkeywithacupcake e1cbc2a
Update skeleton.Rmd
monkeywithacupcake ba39b43
Update skeleton.Rmd
monkeywithacupcake a2062fe
Update skeleton.Rmd
monkeywithacupcake 15e670b
Update skeleton.Rmd
monkeywithacupcake 6036204
Update skeleton.Rmd
monkeywithacupcake c82eaaf
Update skeleton.Rmd
monkeywithacupcake a684d49
Update skeleton.Rmd
monkeywithacupcake c15fe7a
Update jolla.html
monkeywithacupcake 2d698d9
Update jolla.html
monkeywithacupcake 67c5323
Update jolla-blue.html
monkeywithacupcake 451960b
Update onofre.html
monkeywithacupcake d98947f
Update trestles.html
monkeywithacupcake 0487ace
Update skeleton.Rmd
monkeywithacupcake ba7b13f
Update skeleton.Rmd
monkeywithacupcake 9764340
Update skeleton.Rmd
monkeywithacupcake 9e14b5e
Update skeleton.Rmd
monkeywithacupcake 8114fe8
Update onofre.html
monkeywithacupcake 9f9f049
Update onofre.html
monkeywithacupcake 9a7a863
Update onofre.html
monkeywithacupcake bada64e
Update onofre.html
monkeywithacupcake d2c4b8b
Update trestles.html
monkeywithacupcake 4ec0b48
Update jolla.html
monkeywithacupcake 4db11da
Update jolla-blue.html
monkeywithacupcake a509da9
Update README.md
monkeywithacupcake 71a9066
Update README.md
monkeywithacupcake 2198d4f
Update onofre.html
monkeywithacupcake ab1bcb6
Update trestles.html
monkeywithacupcake 7d5395b
Update inst/pandoc_templates/jolla-blue.html
monkeywithacupcake c724bc3
Update jolla-blue.html
monkeywithacupcake 9c10dfe
Update jolla.html
monkeywithacupcake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to
og:image
, I recommend that postcards also support theog:image:alt
andtwitter:image:alt
tags as well. One option would be to addimage_alt
ormeta.image_alt
(or both) to the YAML:The two tags to add would be something like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relatedly,
image_alt
could be added herepostcards/inst/pandoc_templates/solana.html
Line 68 in daad882