-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster_setup_ceph: disable PrivateTmp for ssh during Ceph configuration #679
Draft
Revalioli
wants to merge
2
commits into
main
Choose a base branch
from
fix-private-tmpfs-for-ceph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eroussy
previously approved these changes
Jan 8, 2025
dupremathieu
approved these changes
Jan 8, 2025
playbooks/cluster_setup_ceph.yaml
Outdated
tasks: | ||
- name: Temporarily disable private tmpfs for ssh sessions | ||
lineinfile: | ||
path: /usr/lib/systemd/system/sshd@.service.d/sshd-private-tmp.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file id in ro on Yocto.
Use an systemd override file instead.
dupremathieu
requested changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comment.
Revalioli
force-pushed
the
fix-private-tmpfs-for-ceph
branch
from
January 9, 2025 11:05
82cb85d
to
551e5e1
Compare
Commit [1] in meta-seapath enabled the PrivateTmp systemd option for every ssh sessions with SEAPATH Yocto. This means that every ssh sessions, including ansible ones, will use a separate mount namespace. Any new files in /tmp or new tmpfs during ansible tasks are deleted once the ssh session closes. This is a problem regarding Ceph and ceph-ansible. Directories in /var/lib/ceph/osd/, which contains multiple OSD files, are in fact tmpfs created by ceph-ansible. With the PrivateTmp option, these directories are then lost once the Ansible ssh session closes. As a workaround, temporarily disable the PrivateTmp option for the Ceph configuration via a service override file. Note that this only affects SEAPATH Yocto. [1]: seapath/meta-seapath@22cddd3 Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
"After" setting should be in the Unit section of a systemd service file. Signed-off-by: Elinor Montmasson <elinor.montmasson@savoirfairelinux.com>
Revalioli
force-pushed
the
fix-private-tmpfs-for-ceph
branch
from
January 9, 2025 11:24
551e5e1
to
ffab891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1 in meta-seapath enabled the PrivateTmp systemd option for every ssh sessions with SEAPATH Yocto.
This means that every ssh sessions, including ansible ones, will use a separate mount namespace. Any new files in /tmp or new tmpfs during ansible tasks are deleted once the ssh session closes.
This is a problem regarding Ceph and ceph-ansible. Directories in /var/lib/ceph/osd/, which contains multiple OSD files, are in fact tmpfs created by ceph-ansible. With the PrivateTmp option, these directories are then lost once the Ansible ssh session closes.
As a workaround, temporarily disable the PrivateTmp option for the Ceph configuration.
Note that this only affects SEAPATH Yocto.