Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load bug for large models #41

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix load bug for large models #41

merged 1 commit into from
Mar 13, 2024

Conversation

sebapersson
Copy link
Owner

Before all reactions were collected in a vector. For models with more than 58,000 reactions this caused stackoverflow, now reactions are added one at a time with addreaction!.

@sebapersson sebapersson merged commit 15b7b66 into main Mar 13, 2024
4 checks passed
@sebapersson sebapersson deleted the BigModels branch March 13, 2024 17:35
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (9a4cd00) to head (7f16e44).
Report is 117 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   95.39%   95.38%   -0.01%     
==========================================
  Files          16       16              
  Lines        1759     1778      +19     
==========================================
+ Hits         1678     1696      +18     
- Misses         81       82       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants