-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/psql mariadb support #214
Feature/psql mariadb support #214
Conversation
…SQL compatibility.
Note: Support for logging in with PSQL is provided now.
…tence/conversion issues.
Assuming most DB engines nowadays have connection pooling mechanisms this should be faster.
… logic for item insertion.
…oid multiple schema files.
If you feel it's ready, over the next days I'll test a little bit both a fresh sqlite database and an old sqlite one to ensure everything is compatible with previous setups, and then if all looks good I'll merge it. Thanks a lot for your contributions I'm sure people running a sizable server will greatly appreciate this one |
I'll perform some more manual integration tests on MariaDB & PSQL as well some time this week. I'll also run a test on one of my arm-based systems, that was my original goal, before this spiraled out of control. A lot of the changes I've made to the replace logic I have mostly tested with SQLite, so I don't expect much to pop up there. Thanks a lot for the reviews! It's easy to miss stuff especially with an unknown code base & programming language. |
Tested the following with PSQL/MariaDB on Windows via the IDE setup and via containers:
Haven't tested anything on ARM yet. |
… building for other runtimes, e.g. arm64.
Hi @alborrajo |
I played a bit with SQLite lately. |
It was a mistake on my setup regarding IP addresses in GameServerList.csv, my bad 🙏 |
Add support for PostgreSQL & MariaDB.
This should also improve support for less common hardware (like armv8) to also be supported, as the SQLite drivers are missing there.
Changes:
Performed basic tests on all three (SQLite, PSQL, MariaDB) databases on both Windows & Linux (Docker, linux-x64 & linux-arm64), but might have missed some more obscure transactional use cases.
Checklist:
develop
branch