feat: Add support for GP course effects #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for GP course effects which are configurable by the new file GpCourseInfo.json. Extracted 15 course entries from the packet captures and encoded them into this file. Also added a new custom course called "Arrowgene QOL Course" (quality of life). This is an example of how to create new course effects which were not present when the game was live.
alborrajo
requested changes
Apr 20, 2024
Arrowgene.Ddon.Shared/Entity/PacketStructure/C2LGpCourseGetInfoReq.cs
Outdated
Show resolved
Hide resolved
alborrajo
reviewed
Apr 20, 2024
- Removed unused packet req. - Added icon_path, description and url keys to the json definition.
alborrajo
requested changes
Apr 21, 2024
- Support hot reload of JSON file. - Add known enum names to comment field of effect list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for GP course effects which are configurable by the new file GpCourseInfo.json. Extracted 15 course entries from the packet captures and encoded them into this file. Also added a new custom course called "Arrowgene QOL Course" (quality of life). This is an example of how to create new course effects which were not present when the game was live.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Checklist:
developbranch