feat: Day/Night support for monster spawns #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alborrajo
requested changes
Apr 26, 2024
Arrowgene.Ddon.GameServer/Handler/InstanceGetEnemySetListHandler.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.GameServer/Handler/InstanceGetEnemySetListHandler.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/Entity/Structure/CDataStageLayoutEnemyPresetEnemyInfoClient.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/AssetReader/EnemySpawnAssetDeserializer.cs
Outdated
Show resolved
Hide resolved
|
Fixed a bug present in this PR where night enemies would spawn during the day still, |
alborrajo
reviewed
Apr 27, 2024
alborrajo
requested changes
Apr 27, 2024
Arrowgene.Ddon.GameServer/Handler/InstanceGetEnemySetListHandler.cs
Outdated
Show resolved
Hide resolved
The instance asset manager stores instanced enemies at the time of the first query, alongside their drops and other info. Theyre reset when getting into a safe area
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In combination with the DDOn Tools, you can now assign monsters as "Day & Night", "Day" or "Night" and this will affect when the Monster will spawn, its flexible enough that in the tools you can add a new type and it should just work on the server side!
the defined ranges are based on this supplied info
Spooky image of Skeletons spawned in at night instead of Goblins
This PR comes with an updated enemy JSON, that has every enemy set to the default spawn time (day and night)
bar the first 3 immediate enemies, 3 goblins (day) and 3 skeletons (night)
Checklist:
developbranch