Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Chat RPC commands #292

Merged
merged 7 commits into from
May 11, 2024
Merged

Improvements to Chat RPC commands #292

merged 7 commits into from
May 11, 2024

Conversation

alborrajo
Copy link
Collaborator

  • Include messages posted through RPC in the chat log
  • Allow querying by unix timestamp, not just by formatted date string (more precise)
  • Restrict chat RPC route to accounts with sufficient permissions (GM accounts)

Checklist:

  • The project compiles
  • The PR targets develop branch

@alborrajo alborrajo requested a review from sebastian-heinz May 3, 2024 23:03
@alborrajo
Copy link
Collaborator Author

Also includes the changes in PR #127

@alborrajo alborrajo requested a review from pacampbell May 3, 2024 23:03
@alborrajo alborrajo force-pushed the feature/chatrpc branch 3 times, most recently from 46b9073 to 8840902 Compare May 10, 2024 11:18
@alborrajo alborrajo requested a review from pacampbell May 10, 2024 11:18
@alborrajo alborrajo merged commit ab85b98 into sebastian-heinz:develop May 11, 2024
1 check passed
@alborrajo alborrajo deleted the feature/chatrpc branch May 11, 2024 10:39
@alborrajo alborrajo mentioned this pull request May 11, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastian-heinz sebastian-heinz Awaiting requested review from sebastian-heinz

@pacampbell pacampbell Awaiting requested review from pacampbell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alborrajo @pacampbell @sebastian-heinz