Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempte to fix NPE in LobbyLobbyDataMsgHandler #295

Merged
merged 1 commit into from
May 5, 2024
Merged

attempte to fix NPE in LobbyLobbyDataMsgHandler #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions Arrowgene.Ddon.GameServer/Handler/LobbyLobbyDataMsgHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
using System.Collections.Generic;
using Arrowgene.Buffers;
using Arrowgene.Ddon.GameServer.Party;
using Arrowgene.Ddon.Server;
using Arrowgene.Ddon.Server.Network;
using Arrowgene.Ddon.Shared.Entity.PacketStructure;
using Arrowgene.Ddon.Shared.Entity.RpcPacketStructure;
using Arrowgene.Ddon.Shared.Network;
using Arrowgene.Ddon.Shared.Model;
using Arrowgene.Logging;
using Arrowgene.Ddon.GameServer.Party;

namespace Arrowgene.Ddon.GameServer.Handler
{
Expand Down Expand Up @@ -55,7 +52,7 @@ public override void Handle(GameClient client, StructurePacket<C2SLobbyLobbyData
// We are in one of the common areas where players can see eachother
foreach (GameClient otherClient in Server.ClientLookup.GetAll())
{
if (otherClient == client)
if (otherClient == null || otherClient == client)
alborrajo marked this conversation as resolved.
Show resolved Hide resolved
{
// No point to send to oneself.
continue;
Expand All @@ -66,6 +63,7 @@ public override void Handle(GameClient client, StructurePacket<C2SLobbyLobbyData
otherClient.Send(res);
}
}

}

// Handle additional packet contents
Expand Down
Loading