Added support for a new PPDrop field in enemy information #546
Conversation
Arrowgene.Ddon.Shared/AssetReader/EnemySpawnAssetDeserializer.cs
Outdated
Show resolved
Hide resolved
Arrowgene.Ddon.Shared/Model/Enemy.cs
Outdated
| @@ -68,6 +67,7 @@ public Enemy(Enemy enemy) | |||
| public uint Experience { get; set; } | |||
| public DropsTable DropsTable { get; set; } | |||
| public bool NotifyStrongEnemy { get; set; } | |||
| public uint PPDrop {get; set; } | |||
There was a problem hiding this comment.
nitpick: a space between the { and get;
There was a problem hiding this comment.
I have resolved each of these. I have also explicitly tested it on a server with two enemies, which I had not done before. I set two goblins to have PP drops of 123 and 456. Please check the PR description and you will see an in-game screeenshot demonstrating the PP were dropped. I can also confirm that loading the server with the old JSON (no PPDrop parameter is contained therein) loaded in the expected manner and started the server successfully, though I didn't enter the game and check the PP being dropped.
There was a problem hiding this comment.
the space seems to be missing still 😛
There was a problem hiding this comment.
Fixed - for real this time!
nbfields2
force-pushed
the
395-enemy-playpoint-drop-through-new-optional-field-enemyspawn-json
branch
from
5bb3021
to
733bf6e
Compare
nbfields2
force-pushed
the
395-enemy-playpoint-drop-through-new-optional-field-enemyspawn-json
branch
2 times, most recently
from
f6a432d
to
6390077
Compare
There was a problem hiding this comment.
Does this file work with the server as it is? Wouldn't it reject the file since the schema contains the PPDrop field but the rows don't?
Keep in mind the server starting isn't enough, make sure it starts and loads the file successfully, it's easy to check if you try finding the enemies in their locations
There was a problem hiding this comment.
Apologies - you are correct, it would not work as-is. I did my testing with a different Enemy.cs file that only contained two enemies for easier testing. I removed the extra PPDrop field item.
I can confirm that a file without PPDrop works, and a file with PPDrop and enemies with the correct field also works, in both cases giving the expected amount of Play Points (experience / 7500 or the defined amount respectively).
Arrowgene.Ddon.Shared/Model/Enemy.cs
Outdated
| @@ -68,6 +67,7 @@ public Enemy(Enemy enemy) | |||
| public uint Experience { get; set; } | |||
| public DropsTable DropsTable { get; set; } | |||
| public bool NotifyStrongEnemy { get; set; } | |||
| public uint PPDrop {get; set; } | |||
There was a problem hiding this comment.
the space seems to be missing still 😛
nbfields2
force-pushed
the
395-enemy-playpoint-drop-through-new-optional-field-enemyspawn-json
branch
2 times, most recently
from
fdd022c
to
7d3bfd9
Compare
nbfields2
force-pushed
the
395-enemy-playpoint-drop-through-new-optional-field-enemyspawn-json
branch
from
7d3bfd9
to
7e8fe4e
Compare
|
Thanks for your contribution! |
I have created a new PPDrop field for enemies. It is used to determine the number of Play Points an enemy drops upon defeat. It is to be used as an alternative to the current "Experience / 7500" system. In the case that no number of Play Points is specified, the old system is defaulted to. The below image contains an example of two enemies dropping 456 and 123 PP respectively, which I used as test values for the system.
Checklist:
developbranch