refactor: rework quest enemy spawn #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacampbell
force-pushed
the
quest_enemy_hp_fixes_2
branch
2 times, most recently
from
b19f6ff
to
e9b4b53
Compare
RyanYappert
reviewed
Oct 4, 2024
| var uid = ContextManager.CreateEnemyUID(enemy.Index, enemyGroup.StageId.ToStageLayoutId()); | ||
| if (client.Party.Contexts.ContainsKey(uid)) | ||
| { | ||
| client.Party.Contexts.Remove(uid); |
There was a problem hiding this comment.
Dictionary.Remove is already safe if the dictionary doesn't contain the key; it won't throw an exception.
Removed check for removing items by key from a dictionary
pacampbell
force-pushed
the
quest_enemy_hp_fixes_2
branch
from
e9b4b53
to
6ef5e6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow world monsters to consume a group until the quest reaches a step which requires the group.
Checklist:
developbranch