Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Various fixes related to quests #594

Merged
merged 4 commits into from
Oct 5, 2024
Merged

fix: Various fixes related to quests #594

merged 4 commits into from
Oct 5, 2024

Conversation

pacampbell
Copy link
Collaborator

@pacampbell pacampbell commented Oct 5, 2024 •
edited
Loading

  • Don't populate quest information for quests which are not enabled.
  • Add a new function to check if a quest is enabled which can handle null without causing an exception.
  • Mark Bonus Lobby as a safe area
  • Add potential fix for BGM which don't end
  • Reverted the "improved" quest groups as it doesn't work 100% of the time

Checklist:

  • The project compiles
  • The PR targets develop branch

@pacampbell
fix: Fix few issues related to quest.Enabled
49d28e2 
- Don't populate quest information for quests which are not enabled.
- Add a new function to check if a quest is enabled which can handle
  null without causing an exception.
@pacampbell
fix: Mark Bonus Lobby as a safe area
117077a
@pacampbell
fix: Add potential fix for BGM which don't end
49f6bc6
@pacampbell
revert improved enemy group handling
cb50c6f
@pacampbell pacampbell merged commit 206601e into sebastian-heinz:develop Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pacampbell