Feat: Friends list refactoring #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanYappert
force-pushed
the
feat/friends-refactor
branch
from
fff8860 to
dc0fdf3
Compare
RyanYappert
force-pushed
the
feat/friends-refactor
branch
from
d6b633d to
7b72874
Compare
RyanYappert
force-pushed
the
feat/friends-refactor
branch
from
7b72874 to
5a0ea53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors some of handlers and especially the DB calls relating to the friends/contact list. Originally, these do one query to get a list of contacts, and then for each of those, a separate query to get the Character object associated with it. This is not only many queries not done in a transaction, but contained multiple subqueries for unneeded information. This has been moved into a single query with joins so it should run quite a bit faster.
The various friends list handlers have also been moved to the
GameRequestPacketHandlerframework as well.Checklist:
developbranch