enhance: Add new global modifiers #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added modifiers for gold and rift rewards from quests - Fixed a bug where JP was not modified correctly for quest rewards. - Fixed a bug where exp amounts were not displayed correctly in quest amounts.
Moved default values from constructor to member initialization so it's easier to see when looking at the members. Made modifier types as nullable so they can be assigned a default value if not present in the config json.
pacampbell
force-pushed
the
adjust_quest_base_exp_implementation
branch
from
7a54de7 to
a14e604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
developbranch