Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Crafting Calculation Improvements #661

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

RyanYappert
Copy link
Collaborator

  • Fix cost and speed calculations for crafting.
    • These should now be accurate to the client predictions to within a few gold and/or seconds.
    • Crafting timers are still not implemented.
  • Enable legend pawns where applicable (Crafting, Quality Improvement, and Enhancing)
  • Tweaks to craft analysis to interpret the thing being analyzed better.
  • Adjust pawn crafting assets and crafting tests.
    • The MockServer architecture breaks when tested functions require assets to be loaded, and I don't feel like fixing the crafting tests when this is the second time they've given me trouble.

Checklist:

  • The project compiles
  • The PR targets develop branch

…re applicable. Tweaks to craft analysis to interpret the thing being analyzed better. Adjust pawn crafting assets and crafting tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant