Configurable bazaar timers and bazaar related GP course effects #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacampbell
approved these changes
Dec 19, 2024
| ulong totalCooldown; | ||
| try | ||
| { | ||
| totalCooldown = Server.Setting.GameLogicSetting.BazaarCooldownTimeSeconds - Server.GpCourseManager.BazaarReExhibitShorten(); |
There was a problem hiding this comment.
I feel you could've just checked to see if the shorten time is larger than the time left but I guess this works.
alborrajo
force-pushed
the
feature/bazaar-timers
branch
from
a82afba to
411132c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new game server settings for the bazaar timers BazaarExhibitionTimeSeconds and BazaarCooldownTimeSeconds, with default values of 3 days and 1 day.
Implements the GP course effects that extend bazaar slots and reduces new bazaar cooldown timer
Checklist:
developbranch