Use L3RawSocket(6) automatically on lo

[gpotter2]

Since we already have a mechanism for selecting the L3socket based on the interface (this was designed more towards special bluetooth/usb interfaces), we can very simply add a check to use L3RawSocket(6) when using the loopback interface.

This removes the necessity to use conf.L3socket = L3RawSocket when using loopback.

I am however unsure if this is necessary on BSD/OSX. @guedou what do you think?

[codecov]

Codecov Report

Merging #4099 (6ccbb12) into master (204605b) will increase coverage by 0.35%.
Report is 5 commits behind head on master.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master    #4099      +/-   ##
==========================================
+ Coverage   81.60%   81.96%   +0.35%     
==========================================
  Files         328      328              
  Lines       75766    75867     +101     
==========================================
+ Hits        61832    62183     +351     
+ Misses      13934    13684     -250     

Files Changed	Coverage Δ
scapy/interfaces.py	96.50% <85.71%> (-0.93%)	⬇️
scapy/config.py	84.41% <100.00%> (+0.18%)	⬆️
scapy/sendrecv.py	88.27% <100.00%> (+0.32%)	⬆️

... and 15 files with indirect coverage changes

[guedou]

While you are at it, could you remove the useless backtick at https://github.com/secdev/scapy/blob/master/doc/scapy/troubleshooting.rst?plain=1#L57 ?

[guedou]

Cool PR! On BSD*, the Loopback() layer does a similar job, so we don't need to change anything.

[guedou]

Setting iface= is the best thing to do. I was just wandering why you were changing thisSent from my iPhoneOn 21 Aug 2023, at 19:23, gpotter2 ***@***.***> wrote: @gpotter2 commented on this pull request. In doc/scapy/troubleshooting.rst:

@@ -50,11 +64,20 @@ With IPv6, you can simply do::

<IPv6 version=6 tc=0 fl=866674 plen=8 nh=ICMPv6 hlim=64 src=::1 dst=::1 |<ICMPv6EchoReply type=Echo Reply code=0 cksum=0x7ebb id=0x0 seq=0x0 |>> # Layer 2 - >>> conf.iface = "lo" - >>> srp1(Ether() / IPv6() / ICMPv6EchoRequest()) + >>> srp1(Ether() / IPv6() / ICMPv6EchoRequest(), iface=conf.loopback_name) I'm replacing the conf.iface = "lo" (line above), by iface= in the sniff itself. Do you think that's confusing? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[gpotter2]

I've addressed your points ! Feel free to merge it if you think it's ready.