Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a few more Bluetooth HCI Commands #4103

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Conversation

benquike
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

fixes #xxx

@codecov
Copy link

codecov bot commented Aug 26, 2023

Codecov Report

Merging #4103 (be02a89) into master (8eab848) will increase coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4103      +/-   ##
==========================================
+ Coverage   81.96%   81.98%   +0.01%     
==========================================
  Files         328      328              
  Lines       75918    76027     +109     
==========================================
+ Hits        62224    62327     +103     
- Misses      13694    13700       +6     
Files Changed Coverage Δ
scapy/layers/bluetooth.py 88.24% <100.00%> (+1.14%) ⬆️

... and 12 files with indirect coverage changes

@gpotter2
Copy link
Member

Please fix the PEP8 issues.

@benquike
Copy link
Contributor Author

benquike commented Aug 31, 2023

@gpotter2 Updated, can you please have a look?

@gpotter2 gpotter2 merged commit c57c02b into secdev:master Aug 31, 2023
18 checks passed
@gpotter2
Copy link
Member

Thanks for the PR !

@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants