-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INET6] add the PREF64 ND option #4105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4105 +/- ##
==========================================
- Coverage 81.96% 81.96% -0.01%
==========================================
Files 328 328
Lines 75933 75944 +11
==========================================
+ Hits 62239 62247 +8
- Misses 13694 13697 +3
|
evverx
force-pushed
the
pref64-ra-option
branch
2 times, most recently
from
August 28, 2023 10:50
9b9ec20
to
5e8becc
Compare
guedou
requested changes
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
https://datatracker.ietf.org/doc/html/rfc8781#name-option-format 0 1 2 3 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | Type | Length | Scaled Lifetime | PLC | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ | | + + | Highest 96 bits of the Prefix | + + | | +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ Figure 1: NAT64 Prefix Option Format Fields: Type: 8-bit identifier of the PREF64 option type (38) Length: 8-bit unsigned integer. The length of the option (including the Type and Length fields) is in units of 8 octets. The sender MUST set the length to 2. The receiver MUST ignore the PREF64 option if the Length field value is not 2. Scaled Lifetime: 13-bit unsigned integer. The maximum time in units of 8 seconds over which this NAT64 prefix MAY be used. PLC (Prefix Length Code): 3-bit unsigned integer. This field encodes the NAT64 Prefix Length defined in [RFC6052]. The PLC field values 0, 1, 2, 3, 4, and 5 indicate the NAT64 prefix length of 96, 64, 56, 48, 40, and 32 bits, respectively. The receiver MUST ignore the PREF64 option if the Prefix Length Code field is not set to one of those values. Highest 96 bits of the Prefix: 96-bit unsigned integer. Contains bits 0 - 95 of the NAT64 prefix. The patch was also cross-checked with Wireshark: ICMPv6 Option (PREF64 Option) Type: PREF64 Option (38) Length: 2 (16 bytes) 0000 0111 0000 1... = Scaled Lifetime: 225 .... .... .... .001 = PLC (Prefix Length Code): 64 bits prefix length (0x1) Prefix: 2003:da8:1:: (It's mostly prompted by systemd/systemd#28985)
evverx
force-pushed
the
pref64-ra-option
branch
from
August 28, 2023 12:39
5e8becc
to
bb38bdc
Compare
guedou
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://datatracker.ietf.org/doc/html/rfc8781#name-option-format
The patch was also cross-checked with Wireshark:
(It's mostly prompted by systemd/systemd#28985)