Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Scapy load on unsupported platforms #4111

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Sep 3, 2023

  • let Scapy load on unsupported platforms
    • mock the required arch functions (read_routes, etc.)
    • fix a dependency loop on those platforms, by putting L3RawSocket6 next to its brother L3RawSocket

It's still miserable but at least it loads.

@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #4111 (b4e5e76) into master (f0843cc) will decrease coverage by 0.02%.
The diff coverage is 15.00%.

@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
- Coverage   81.95%   81.93%   -0.02%     
==========================================
  Files         330      330              
  Lines       76145    76161      +16     
==========================================
+ Hits        62405    62406       +1     
- Misses      13740    13755      +15     
Files Changed Coverage Δ
scapy/arch/__init__.py 73.43% <0.00%> (-16.95%) ⬇️
scapy/config.py 84.33% <0.00%> (+0.34%) ⬆️
scapy/interfaces.py 96.60% <0.00%> (ø)
scapy/supersocket.py 74.77% <50.00%> (-1.43%) ⬇️

... and 3 files with indirect coverage changes

@p-l- p-l- merged commit 353b241 into secdev:master Sep 7, 2023
18 checks passed
@p-l-
Copy link
Member

p-l- commented Sep 7, 2023

Thanks @gpotter2, that's a great idea! No reason one cannot dissect packets from a PCAP file on an unsupported platform!

@gpotter2 gpotter2 deleted the miserable branch September 7, 2023 21:52
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants