Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ESP padding in decryption #4123

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

ppachocki
Copy link
Contributor

This PR corrects the value of the padding field of the _ESPPlain instance returned by decrypt method in CryptAlgo class.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #4123 (4c9568f) into master (63838a3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
- Coverage   81.95%   81.94%   -0.01%     
==========================================
  Files         330      330              
  Lines       76200    76200              
==========================================
- Hits        62449    62443       -6     
- Misses      13751    13757       +6     
Files Changed Coverage Δ
scapy/layers/ipsec.py 88.80% <100.00%> (ø)

... and 9 files with indirect coverage changes

@p-l-
Copy link
Member

p-l- commented Sep 15, 2023

HI there, thanks for your PR. Could you add a test that is broken before your PR and fixed with it? Also, it would greatly help the maintainers if you could provide explanations about your change. Thanks!

@gpotter2
Copy link
Member

The fix looks right altough a test would be nice.

@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
scapy/layers/ipsec.py Show resolved Hide resolved
@gpotter2 gpotter2 merged commit 03bb705 into secdev:master Feb 4, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants