Fix UDP header in IPSec NAT-Traversal. #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4125 +/- ##
==========================================
- Coverage 81.95% 81.95% -0.01%
==========================================
Files 330 330
Lines 76200 76211 +11
==========================================
+ Hits 62449 62456 +7
- Misses 13751 13755 +4
|
|
Could you share an example of the issue reproducer and add it as a unit test? |
guedou
reviewed
Sep 18, 2023
guedou
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the statement on line 1051 (
ip_header = ip_header.__class__(raw(ip_header))), the value of thelenfield in the UDP header was set to 8 and the ESP layer in the packet was seen as padding.