Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSLv2] s/debug_dissect/debug_dissector/ #4129

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Sep 19, 2023

to prevent do_dissect_payload from failing with

  File "scapy/scapy/layers/tls/record_sslv2.py", line 177, in do_dissect_payload
    if conf.debug_dissect:
       ^^^^^^^^^^^^^^^^^^
  File "scapy/scapy/config.py", line 950, in __getattribute__
    return object.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Conf' object has no attribute 'debug_dissect'

The test is added to exercise the Exception clause.

(I accidentally spotted it in #4082 (comment) but forgot to send a PR)

to prevent do_dissect_payload from failing with
```
  File "scapy/scapy/layers/tls/record_sslv2.py", line 177, in do_dissect_payload
    if conf.debug_dissect:
       ^^^^^^^^^^^^^^^^^^
  File "scapy/scapy/config.py", line 950, in __getattribute__
    return object.__getattribute__(self, attr)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'Conf' object has no attribute 'debug_dissect'
```

The test is added to exercise the Exception clause.
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #4129 (57c5fa5) into master (219f2fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4129   +/-   ##
=======================================
  Coverage   80.95%   80.96%           
=======================================
  Files         330      330           
  Lines       76234    76234           
=======================================
+ Hits        61714    61721    +7     
+ Misses      14520    14513    -7     
Files Changed Coverage Δ
scapy/layers/tls/record_sslv2.py 90.50% <100.00%> (+4.46%) ⬆️

... and 3 files with indirect coverage changes

@gpotter2 gpotter2 merged commit 4b386ff into secdev:master Sep 21, 2023
18 of 19 checks passed
@gpotter2 gpotter2 added this to the 2.6.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants