Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add piper example #145

Merged
merged 13 commits into from
Aug 6, 2024
Merged

Add piper example #145

merged 13 commits into from
Aug 6, 2024

Conversation

PeterD1524
Copy link
Contributor

I am working on LFX Workspace: Support piper as a new backend of the WASI-NN WasmEdge plugin #3483.
This PR adds a basic example of using the plugin to perform text-to-speech.

Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Copy link
Member

juntao commented Jun 28, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit b3c64f2a2acf2a758c4451f7f54f93ca05689a92

Key Changes:

  1. Added a new Cargo.toml file with dependencies on serde_json and wasmedge-wasi-nn.
  2. Added a new README.md file with instructions on how to use the WasmEdge WASI-NN Piper plugin for Text-to-Speech (TTS).
  3. Added a new main.rs file with Rust code for creating a TTS graph using the WasmEdge WASI-NN Piper plugin.

Potential Problems:

  1. The patch seems to add a lot of new functionality related to Text-to-Speech using the WasmEdge WASI-NN Piper plugin without mentioning any specific issues or bugs. It would be helpful to have clear information on the purpose of these changes and if they are solving a particular problem or adding new features.
  2. The patch introduces new dependencies like serde_json and wasmedge-wasi-nn. It is essential to ensure that these dependencies are necessary and do not introduce security vulnerabilities or conflicts with existing dependencies.
  3. The patch adds complex build and execution instructions in the README.md file. It is important to verify the accuracy and completeness of these instructions to ensure that users can successfully build and execute the project.
  4. The main.rs code adds functionality for TTS using the WasmEdge WASI-NN Piper plugin. It is crucial to review the code for performance optimizations, error handling, and best practices in Rust programming.
  5. The patch includes external links for model download and additional resources. It is important to ensure that these links are valid, secure, and relevant to the project.

Overall, the patch introduces significant changes related to TTS functionality using the WasmEdge WASI-NN Piper plugin. Reviewing the code, dependencies, instructions, and external resources thoroughly will be crucial to ensure the quality and reliability of the added functionality.

Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dm4 PTAL

@dm4
Copy link
Member

dm4 commented Jul 15, 2024

Could you please help add the following items? Thank you!

  1. Provide a simple explanation of the related dependency installation in the README.md, such as libespeak-ng, libonnxruntime, libpiper, etc.
  2. Add a GitHub workflow in .github/workflows/piper.yml to ensure that the example can run successfully.

@dm4 dm4 self-requested a review July 15, 2024 08:24
wasmedge-piper/Cargo.toml Outdated Show resolved Hide resolved
PeterD1524 and others added 7 commits July 16, 2024 07:37
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
@PeterD1524
Copy link
Contributor Author

@dm4 I have added the following items.

  1. Provide a simple explanation of the related dependency installation in the README.md, such as libespeak-ng, libonnxruntime, libpiper, etc.

075409e

  1. Add a GitHub workflow in .github/workflows/piper.yml to ensure that the example can run successfully.

870e600

.github/workflows/piper.yml Outdated Show resolved Hide resolved
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @dm4 PTAL.

Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
.github/workflows/piper.yml Outdated Show resolved Hide resolved
Signed-off-by: PeterD1524 <qaz246135@gmail.com>
@hydai hydai merged commit de9c3e6 into second-state:master Aug 6, 2024
1 check passed
@PeterD1524 PeterD1524 deleted the piper branch September 3, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants