Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Verify b3499 #154

Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE Verify b3499 #154

wants to merge 1 commit into from

Conversation

hydai
Copy link
Member

@hydai hydai commented Aug 1, 2024

No description provided.

Copy link
Member

juntao commented Aug 1, 2024

Hello, I am a code review agent on flows.network. Here are my reviews of changed source code files in this PR.


.github/workflows/llama.yml

Potential issues

The code is a GitHub Actions workflow configuration file for the project "ggml llama2 examples". It contains multiple jobs, each running on either Ubuntu 20.04 or macOS M1, and using WasmEdge versions 0.13.5 or 0.14.0 with the wasi_nn-ggml-b3499 plugin. Each job downloads a specific model file (like TinyLlama, Gemma, Llava, Llama2, StarCoder, etc.) and runs it using WasmEdge and GGML.

Bug:

  1. In the "Llama3 8B" and "Llama3 8B (Streaming)" jobs, the system prompt is not properly formatted for Llama3 models, causing incorrect responses.

Summary of changes

  • The plugin version for the "Tiny Llama" job has been updated from wasi_nn-ggml to wasi_nn-ggml-b3499.
  • Several test jobs related to different versions and configurations of Phi 3 models have been removed.
  • The remaining test job, "JSON Schema", appears to be unchanged in this patch.

This update mainly involves changes in the configuration for running tests, specifically updating the plugin version used and removing some specific model tests.

Signed-off-by: hydai <z54981220@gmail.com>
@hydai
Copy link
Member Author

hydai commented Aug 4, 2024

Verified. Closing

@hydai hydai closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants