feat: don't filter data file by extname (#63)

secretflow · Oct 9, 2024 · 992023d · 992023d
1 parent 3b84c70
commit 992023d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/packages/secretnote-lite/package.json b/packages/secretnote-lite/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@alipay/secretnote-lite",
-  "version": "0.0.43",
+  "version": "0.0.44",
   "license": "Apache-2.0",
   "author": "vectorse@126.com",
   "repository": "https://github.com/secretflow/secretnote/tree/main/packages/secretnote",

diff --git a/packages/secretnote-lite/src/modules/file/service.ts b/packages/secretnote-lite/src/modules/file/service.ts
@@ -12,7 +12,6 @@ import {
 import { SecretNoteServerManager, ServerStatus } from '../server';
 
 export const BASE_PATH = '/';
-export const FILE_EXTS = ['.csv', '.log', '.txt', '.jsonl'];
 @singleton()
 export class FileService {
   protected readonly contentsManager: ContentsManager;
@@ -183,8 +182,7 @@ export class FileService {
   }
 
   private isFileVisible(path: string) {
-    const ext = this.getFileExtByPath(path);
-    return FILE_EXTS.includes(`.${ext}`);
+    return true; // let all files be visible
   }
 
   private onServerChanged() {

diff --git a/packages/secretnote-lite/src/modules/file/view.tsx b/packages/secretnote-lite/src/modules/file/view.tsx
@@ -31,7 +31,7 @@ import { SideBarContribution } from '@/modules/layout';
 import { genericErrorHandler, readFile } from '@/utils';
 
 import './index.less';
-import { FILE_EXTS, FileService } from './service';
+import { FileService } from './service';
 
 const { DirectoryTree } = Tree;
 
@@ -97,7 +97,6 @@ export const FileComponent = () => {
 
   const uploadRender = (nodeData: DataNode) => {
     const props: UploadProps = {
-      accept: FILE_EXTS.join(','),
       beforeUpload: async (file) => {
         const isExisted = await fileService.isFileExist(nodeData, file.name);
         if (isExisted) {