Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: component attr lowerBound as empty object and type as integer #39

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

z0gSh1u
Copy link
Collaborator

@z0gSh1u z0gSh1u commented Mar 25, 2024

  • when the sf component spec has "lowerBound": {}, the lower bound should be zero
  • some lower bounds are inclusive while some are exclusive
  • AT_INT type should map to integer inside schema form.

Copy link

changeset-bot bot commented Mar 25, 2024

⚠️ No Changeset found

Latest commit: f17ce6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@z0gSh1u z0gSh1u marked this pull request as draft March 26, 2024 09:45
@z0gSh1u z0gSh1u force-pushed the zx/dev branch 2 times, most recently from d7dc348 to 4481cb3 Compare March 27, 2024 02:24
@z0gSh1u z0gSh1u marked this pull request as ready for review March 27, 2024 02:36
@NewByVector NewByVector merged commit 18caa8d into main Mar 27, 2024
5 checks passed
@NewByVector NewByVector deleted the zx/dev branch March 27, 2024 02:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants