Changed LoadKeyFromSSLibBytes to Support RSA Keys #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neilnaveen
commented
Nov 7, 2023
neilnaveen
commented
- Changed LoadKeyFromSSLibBytes to support RSA keys
- Seperated LoadRSAPSSKeyFromFile into helper function LoadRSAPSSKeyFromBytes so that data can be passed as a byte array or as a file name.
- Made LoadRSAPSSKeyFromBytes into an exported function to use in Support Loading Key for RSA gittuf/gittuf#174
- Added test for RSA key to SSLibKey for LoadKeyFromSSLibbytes
- Changed LoadKeyFromSSLibBytes to support RSA keys - Seperated LoadRSAPSSKeyFromFile into helper function LoadRSAPSSKeyFromBytes so that data can be passed as a byte array or as a file name. - Made LoadRSAPSSKeyFromBytes into an exported function to use in gittuf/gittuf#174 - Added test for RSA key to SSLibKey for LoadKeyFromSSLibbytes Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
alanssitis
reviewed
Nov 9, 2023
Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
alanssitis
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
LGTM, I don't have permissions. @adityasaky may have other comments.
adityasaky
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
Minor nits, but I think this is fine. @mnm678 can you take a look too? Thanks!
signerverifier/rsa.go
Outdated
|
|
||
| // LoadRSAPSSKeyFromFile returns an SSLibKey instance for an RSA key stored in a |
There was a problem hiding this comment.
Can you add some information about the expected encoding of the key in the file?
There was a problem hiding this comment.
I have expanded on this, if their is something else you would like to add, tell me
There was a problem hiding this comment.
Could you indicate the RSA key is expected to be PEM encoded on disk?
|
Also, looks like |
Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
adityasaky
approved these changes
Nov 20, 2023
Signed-off-by: neilnaveen <42328488+neilnaveen@users.noreply.github.com>
mnm678
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.