-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add unit tests to rhtap #14
add unit tests to rhtap #14
Conversation
Signed-off-by: Lance Ball <lball@redhat.com>
Update RHTAP references
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JasonPowr The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If you can access the links you can see them passing, you can also view the logs to confirm |
/retest |
c3d903d
to
2d56a15
Compare
@JasonPowr this PR needs to be rebased, can you please take a look? |
Apologies I forgot this pr was still open, This pr is out of date for the new workspace, ill resolve my changes and basically remove them as you have commits here, ill follow up with a pr for the new workspace for unit tests :) |
Signed-off-by: Jason Power <japower@redhat.com>
closing this instead, as the only changes are to the patch file thats not needed anymore |
This pr adds unit testing to rhtap for fulcio. I've created my own version of fulcio in rhtap in my own workspace and have tested the changes.
Comments
I only went with that image as its the same used in the Docker files, if it needs to be changed let me know 👍
I believe fulcio can be removed off of open shift release now