Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit tests to rhtap #14

Closed

Conversation

JasonPowr
Copy link

This pr adds unit testing to rhtap for fulcio. I've created my own version of fulcio in rhtap in my own workspace and have tested the changes.

Comments

I only went with that image as its the same used in the Docker files, if it needs to be changed let me know 👍
I believe fulcio can be removed off of open shift release now

@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JasonPowr
Once this PR has been reviewed and has the lgtm label, please assign lance for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JasonPowr
Copy link
Author

If you can access the links you can see them passing, you can also view the logs to confirm

  1. https://console.redhat.com/preview/application-pipeline/workspaces/securesign/applications/fulcio/pipelineruns/fulcio-on-pull-request-9pqxx

@lance
Copy link
Member

lance commented Sep 26, 2023

/retest

@lance
Copy link
Member

lance commented Oct 17, 2023

@JasonPowr this PR needs to be rebased, can you please take a look?

@JasonPowr
Copy link
Author

@JasonPowr this PR needs to be rebased, can you please take a look?

Apologies I forgot this pr was still open, This pr is out of date for the new workspace, ill resolve my changes and basically remove them as you have commits here, ill follow up with a pr for the new workspace for unit tests :)

Signed-off-by: Jason Power <japower@redhat.com>
@JasonPowr
Copy link
Author

closing this instead, as the only changes are to the patch file thats not needed anymore

@JasonPowr JasonPowr closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants