optional expire flags + automated versioning #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SequeI
force-pushed
the
asiek/updateSubset
branch
7 times, most recently
from
c1edaee
to
43c7571
Compare
|
/retest |
SequeI
force-pushed
the
asiek/updateSubset
branch
2 times, most recently
from
4110035
to
a6af040
Compare
bkabrda
approved these changes
Sep 6, 2024
fghanmi
approved these changes
Sep 6, 2024
|
/hold |
SequeI
force-pushed
the
asiek/updateSubset
branch
from
a6af040
to
67d6078
Compare
|
/unhold |
fghanmi
approved these changes
Sep 9, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bkabrda, fghanmi, SequeI The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding expiry values to all metadata files when using tuftool update is now optional, a user can just supply a variation of any he wants and the pre-existing expiry values that were not specified with a flag will be passed on to the new version.
Versioning has been removed from the users hands, now it will automatically calculate a new version removing the issue of overwriting pre existing metadata files and adding general QoL. A --force-version flag exists to forcefully change the version of a specific metadata file.