Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 📝 Update team docs based on iteration retrospective #121

Merged
merged 4 commits into from
Mar 12, 2024
Merged

docs: 📝 Update team docs based on iteration retrospective #121

merged 4 commits into from
Mar 12, 2024

Conversation

lwjohnst86
Copy link
Member

Description

  • This PR updates the team docs based on the retrospective of the last iteration.

Reviewer Focus

This PR only needs a quick review.

@lwjohnst86 lwjohnst86 requested a review from a team as a code owner March 7, 2024 09:03
@lwjohnst86 lwjohnst86 changed the title chore: 📝 Convert check boxes to regular list items (they don't need to be checkboxes) docs: 📝 Update team docs based on iteration retrospective Mar 7, 2024
philter87
philter87 previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@philter87 philter87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, Iterations and 1 approver 🎉

signekb
signekb reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Just have some minor comments and formatting suggestions.

entries/update-meetings.qmd Outdated Show resolved Hide resolved
events/2023-06-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-06-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-06-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-06-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-10-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-10-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-10-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-10-in-person/index.qmd Outdated Show resolved Hide resolved
events/2023-10-in-person/index.qmd Outdated Show resolved Hide resolved
@lwjohnst86 @signekb
docs: Apply suggestions from code review
27ec31e 
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
K-Beicher
K-Beicher reviewed Mar 11, 2024
View reviewed changes
Copy link
Contributor

@K-Beicher K-Beicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@lwjohnst86
Copy link
Member Author

@K-Beicher if you approve it, can you click approve instead of comment? 🙏🏻

K-Beicher
K-Beicher approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@K-Beicher K-Beicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll pick the right radio button this time :-)

@lwjohnst86 lwjohnst86 merged commit 9e73e91 into main Mar 12, 2024
@lwjohnst86 lwjohnst86 deleted the docs/updates-from-retrospective branch March 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@signekb signekb signekb left review comments

@K-Beicher K-Beicher K-Beicher approved these changes

@philter87 philter87 philter87 left review comments

Assignees

@lwjohnst86 lwjohnst86

Labels
None yet
Projects
Team project planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lwjohnst86 @philter87 @signekb @K-Beicher