Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor layout a little bit #154

Merged
merged 2 commits into from
May 31, 2024
Merged

Refactor layout a little bit #154

merged 2 commits into from
May 31, 2024

Conversation

martonvago
Copy link
Contributor

Description

  • This PR renames the "entries" section/folder/page to "how we work". This was already the name of the section on the index page, and I thought having the same name there and in the sidebar made sense. Plus, it's also less vague than "entries".
  • I've also removed "onboarding" from the section title on the index page, because to me it looked a bit weird that it was both the title and an item within the section. But this is pretty subjective, so happy to revert.

team-index

Closes #146

Testing

  • Yes
  • No, not needed (give a reason below)
  • No, I need help writing them

Tested in the browser.

Reviewer Focus

This PR only needs a quick review.

Checklist

For all PRs that are not general documentation

  • Tests accompany or reflect changes to the code
  • Tests ran and passed locally
  • Ran the linter and formatter
  • Build has passed locally
  • Relevant documentation has been updated

@martonvago martonvago self-assigned this May 31, 2024
@martonvago martonvago requested a review from a team as a code owner May 31, 2024 09:43
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like! Thanks!!

@lwjohnst86 lwjohnst86 merged commit 18be566 into main May 31, 2024
1 check passed
@lwjohnst86 lwjohnst86 deleted the refactor/layout-improvements branch May 31, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Minor UI improvements
2 participants