Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🔧 Added devcontainer file. Needs to be tested first! #75

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

lwjohnst86
Copy link
Member

I haven't fully been able to test it, since I think I have issues with my Docker install. But I think it should work. Can any of you test it out by pulling this branch, opening the project in VS Code and selecting the pop-up that says "open in Dev Container". Then after it builds and starts up, go to the Terminal and type out "just build-website".

Closes #32

I haven't fully been able to test it, since I think I have issues with my Docker install. But I think it should work.

Closes #32
@K-Beicher
Copy link
Contributor

Tried to, I'm sure I'm just missing a step here, what do I need to run in order to get the pop-up?

@lwjohnst86
Copy link
Member Author

ah you're right, I forgot to add the vscode extension to the vscode folder. I'll fix that than push it up

@lwjohnst86
Copy link
Member Author

I added it. The other thing I forgot to mention is that to open the Dev Container, you also need open Docker, so it is running in the background.

@K-Beicher
Copy link
Contributor

Tested and works fine here

@signekb
Copy link
Member

signekb commented Dec 4, 2023

I'm not getting the pop-up to open in a dev container. I have Docker Desktop open (and have switched to the feat/devcontainer branch ofc). What am I missing? @K-Beicher @lwjohnst86

@lwjohnst86
Copy link
Member Author

Have you installed the recommended extensions? Otherwise, try using the command palette and typing "reopen in dev container".

@K-Beicher
Copy link
Contributor

It may also be that the notification just didn't pop up, mine disappear after a short while.

@K-Beicher
Copy link
Contributor

Just for future reference, the notification may be hiding, in which case it can be found by clicking on the bell icon in the bottom right corner.

@signekb
Copy link
Member

signekb commented Dec 4, 2023

AH, I found the little notification bell with @K-Beicher 's help. Not exactly screaming for attention 😛
It seems to work here as well!

@signekb
Copy link
Member

signekb commented Dec 4, 2023

@lwjohnst86
Do we want the vs extensions we use to come installed in the dev container? Or do we want to keep that separate?
Screenshot 2023-12-04 at 09 47 14

@lwjohnst86
Copy link
Member Author

@signekb hmmm, I think because we have the recommended extensions already in the settings.json file, it will install them after you've opened the devcontainer and selected "yes" to installing the recommended extensions. There might be a way to install it automatically though. The tricky part is the devcontainers aren't just a vscode thing, but also available in PyCharm. Which doesn't have extensions.

@signekb
Copy link
Member

signekb commented Dec 6, 2023

@lwjohnst86 Ah, yeah, very good point. I think you're right - let's keep the extensions in the .vscode/settings.json

@signekb signekb self-requested a review December 10, 2023 13:40
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me too 👍
Added myself as reviewer so it can be merged (2 reviews needed)

@lwjohnst86 lwjohnst86 merged commit 0b76185 into main Dec 11, 2023
@lwjohnst86 lwjohnst86 deleted the feat/devcontainer branch December 11, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Easier team development with Dev containers
3 participants