-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🔧 Added devcontainer file. Needs to be tested first! #75
Conversation
I haven't fully been able to test it, since I think I have issues with my Docker install. But I think it should work. Closes #32
Tried to, I'm sure I'm just missing a step here, what do I need to run in order to get the pop-up? |
ah you're right, I forgot to add the vscode extension to the vscode folder. I'll fix that than push it up |
I added it. The other thing I forgot to mention is that to open the Dev Container, you also need open Docker, so it is running in the background. |
Tested and works fine here |
I'm not getting the pop-up to open in a dev container. I have Docker Desktop open (and have switched to the feat/devcontainer branch ofc). What am I missing? @K-Beicher @lwjohnst86 |
Have you installed the recommended extensions? Otherwise, try using the command palette and typing "reopen in dev container". |
It may also be that the notification just didn't pop up, mine disappear after a short while. |
Just for future reference, the notification may be hiding, in which case it can be found by clicking on the bell icon in the bottom right corner. |
AH, I found the little notification bell with @K-Beicher 's help. Not exactly screaming for attention 😛 |
@lwjohnst86 |
@signekb hmmm, I think because we have the recommended extensions already in the |
@lwjohnst86 Ah, yeah, very good point. I think you're right - let's keep the extensions in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me too 👍
Added myself as reviewer so it can be merged (2 reviews needed)
I haven't fully been able to test it, since I think I have issues with my Docker install. But I think it should work. Can any of you test it out by pulling this branch, opening the project in VS Code and selecting the pop-up that says "open in Dev Container". Then after it builds and starts up, go to the Terminal and type out "just build-website".
Closes #32