Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump TypeScript Eslint #136

Merged
merged 8 commits into from
Mar 24, 2024
Merged

Bump TypeScript Eslint #136

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0a4b44f
Bump typescript-eslint
samchungy Mar 12, 2024
c3f5bf5
bump more things
samchungy Mar 12, 2024
342d4dc
Breaking Change Changeset
samchungy Mar 12, 2024
9d6c69c
wordsmith
samchungy Mar 12, 2024
49036b1
add extra mentions of eslint and typescript
samchungy Mar 12, 2024
92258c7
remove >=
samchungy Mar 12, 2024
59dac53
remove renovate
samchungy Mar 12, 2024
355537b
Bump volta version
samchungy Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/soft-penguins-eat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'eslint-config-seek': major
---

Upgrade Typescript Eslint to 7.2.0 to support Typescript 5.4.

This also bumps minimum required node version to 18.18.0 due to a breaking change introduced by Typescript Eslint in 7.0.0.
3 changes: 3 additions & 0 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
extends: ['github>seek-oss/rynovate'],
samchungy marked this conversation as resolved.
Show resolved Hide resolved
}
17 changes: 10 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,12 @@
"@babel/eslint-parser": "^7.22.6",
"@babel/preset-react": "^7.22.5",
"@finsit/eslint-plugin-cypress": "^3.1.1",
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"@typescript-eslint/eslint-plugin": "^7.2.0",
"@typescript-eslint/parser": "^7.2.0",
"eslint-config-prettier": "^8.8.0",
"eslint-import-resolver-typescript": "3.5.5",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-jest": "^27.2.3",
"eslint-plugin-jest": "^27.9.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting some pnpm warnings about peer dep versions not matching

"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-rulesdir": "^0.2.2",
Expand All @@ -43,13 +43,16 @@
"devDependencies": {
"@changesets/cli": "^2.26.2",
"@changesets/get-github-info": "^0.5.2",
"eslint": "^8.44.0",
"eslint": "^8.56.0",
"prettier": "^2.8.4",
"typescript": "~5.1.6"
"typescript": "~5.4.2"
},
"peerDependencies": {
"eslint": ">=7",
"typescript": ">=4.5"
"eslint": ">=8.56.0",
"typescript": ">=4.7.5"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are requirements of Typescript Eslint

},
"engines": {
"node": ">=18.18.0"
},
"packageManager": "pnpm@8.6.6",
"volta": {
samchungy marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading
Loading