Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents snapshots if there are no creators. #1592

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Prevents snapshots if there are no creators. #1592

merged 5 commits into from
Sep 28, 2023

Conversation

fherreazcue
Copy link
Collaborator

@fherreazcue fherreazcue commented Sep 20, 2023 •
edited
Loading

This avoids issues with DOI generation.

Resolves #1390

@fherreazcue fherreazcue linked an issue Sep 20, 2023 that may be closed by this pull request
Check for creators before creating a snapshot #1390
Closed
fbacall
fbacall requested changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@fbacall fbacall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor tweaks needed

test/functional/snapshots_controller_test.rb Outdated Show resolved Hide resolved
lib/seek/research_objects/acts_as_snapshottable.rb Outdated Show resolved Hide resolved
@stuzart stuzart merged commit 3133efa into main Sep 28, 2023
25 checks passed
@stuzart stuzart deleted the snapshot_creators branch September 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuzart stuzart stuzart approved these changes

@fbacall fbacall Awaiting requested review from fbacall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for creators before creating a snapshot
3 participants
@fherreazcue @stuzart @fbacall