Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composable events #34

Open
wants to merge 61 commits into
base: trunk
Choose a base branch
from
Open

Composable events #34

wants to merge 61 commits into from

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Sep 15, 2024

Depends on #33

@gibbz00
refactor(ari): extract error to separate crate
aa20a8b
@gibbz00
refactor(ari): extract Event to separate crate
67aaaab
@gibbz00
feat(ari): temporarily remove #[instrument] annotations
1be37d6
@gibbz00
reactor!(ari): use top module star imports
00dcd0a
@gibbz00
reactor(ari): use idiomatic code ordering in client.rs
991b0ee
@gibbz00
feat(ari): remove tracing events from client builder
7dd2e9b
@gibbz00
refactor!(ari): encapsulate Client fields
c1cee13
@gibbz00
feat(ari): use unbounded event channels
2fb8f3b
@gibbz00
feat!(ari): inline websocket channel setup in client
87161d8
@gibbz00
refactor(ari): move RequestClient to its own file
853fccb
@gibbz00
refactor!(ari): invert ownership if Channel requests
c77b1ba
@gibbz00
refactor!(ari/channel): require channel_id only in request calls
218d52c
@gibbz00
refactor!(ari/channel): make fields private and supply getters instead
3994668
@gibbz00
refactor!(ari/channel): initial serde_qs integration
776aabe
@gibbz00
refactor!(ari/channel): continued serde_qs integration
380ad35
@gibbz00
feat!(ari/channel): remove tracing event logging
b6d70ca 
Libraries should avoid locking in logging solutions. Future work could
instead instrument the function behind a feature flag.
@gibbz00
perf(ari/channel): avoid recreating reqwest::Client on every request
a179808
@gibbz00
refactor(ari): add RequestClient.authorized_delete
ee6c5e2
@gibbz00
refactor(ari): add RequestClient.authorized_post
ae76bfa
@gibbz00
refactor(ari): add RequestClient.authorized_post_json_response
1b32aca
@gibbz00
refactor(ari): add RequestClient.authorized_post_variables
e4a3eb4
@gibbz00
refactor(ari): add RequestClient.authorized_get
794b588
@gibbz00
refactor!(ari): make DeviceStateChanged private in event module
8f5860f
@gibbz00
refactor!(ari): invert self to RequestClient in playback
44cad89
@gibbz00
refactor!(ari): cleanup and place RtpStastistics in channel module
ae8f77e
@gibbz00
refactor!(ari): invert self to RequestClient in bridge
c159aed
@gibbz00
feat!(ari): prefix live_recording_ to live recording requests
ae74c59
@gibbz00
feat!(ari): prefix stored_recording_ to stored recording requests
0026f81
@gibbz00
refactor!(ari): invert self to RequestClient in recording
eb604be
@gibbz00
refactor!(ari): cleanup and place Variable in channel module
4c55e58
@gibbz00
refactor(ari): place bridge and channel handling under `request_c…
d47bc02 
…lient` module
@gibbz00
refactor(ari): place recording handling under request_client module
0a269cd
@gibbz00
chore(ari): go over RequestClient method visibilities
2c3dadc
@gibbz00
perf(ari): memoize API key
cd6bf59
@gibbz00
chore(ari): make AuthorizedRequest private
e4576bd
@gibbz00
refactor(ari): prefix bridge client requests with bridge_
2a26a4f
@gibbz00
refactor(ari): prefix channel client requests with channel_
81b610f
@gibbz00
refactor(ari): prefix playback client requests with playback_
cbd424a
@gibbz00
feat!(ari): go over WebSocket event handling
ddc3b3d 
Also removes `tracing` library lock-in.
@gibbz00
feat!(ari): add ClientError
a45a38c 
Begin moving away from crate-wide error.
@gibbz00
chore!(ari): remove AriError::Tungstenite
c9995c7
@gibbz00
chore!(ari): remove AriError::Unknown
844764d
@gibbz00
chore!(ari): remove AriError::UrlParse
fddd6b1
@gibbz00
refactor!(ari): replace AriError with RequestClientError
336df7c
@gibbz00
refactor(ari): remove fully qualified std::result::Result usage
228921e
@gibbz00
refactor!(ari): rename Client to Asterisk
8b2d75c
@gibbz00
refactor!(ari): rename RequestClient to AriClient
d04e79f
@gibbz00
chore(ari): go over tokio feature flags
b1d2bd3
@gibbz00
chore(ari): replace qualified chrono::Utc with use
782ee7c
@gibbz00
chore(ari): remove misleading patch version from Cargo.toml
424992f
@gibbz00
chore: place crates in a crates directory
84a122a
@gibbz00
chore: consolidate packages attributes to workspace
6e4e72a
@gibbz00
chore: use workspace dependencies
e8099b1
@gibbz00
chore: remove common rs postfix from crate directory names
233bc4c
@gibbz00
feat!: change crate names to improve discovery and identifiability
46a5075
@gibbz00
refactor: move event types to event module
f1ed531
@gibbz00
refactor: compose common event data with an Event<D> struct
588be1e
@gibbz00
feat(ari): add missing StasisStart.replace_channel field
8562bc0
This was referenced Sep 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gibbz00